Teach compiletest to ignore platform triples#67334
Merged
bors merged 2 commits intorust-lang:masterfrom Dec 29, 2019
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI tests are written assuming
--remap-path-prefixis not used (remap-debuginfoinconfig.toml). The consequence is that the error messages may include paths and snippets into the standard library. Whenremap-debuginfois enabled, these messages change in format and structure becauserustcwill not show paths and snippets into the standard library.This normally isn't a problem for the "main" platforms (linux/macos/windows), because the CI infrastructure is set up so that the tests run without
remap-debuginfo, but thedistartifacts are built separately withremap-debuginfoenabled. However, some of the lower-tier platforms perform both tests and distribution in a single step withremap-debuginfoenabled. This also affects developers and distributors who useremap-debuginfo.To sidestep this problem, we add a way to ignore tests in specific platform triples, and update the overly broad
ignore-x86rule in affected tests.Address #46948, #54546, #53081.